| From 9028777479d4d063f3688795784dd399303019c8 Mon Sep 17 00:00:00 2001 |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Date: Mon, 18 Mar 2019 21:47:09 +0300 |
| Subject: ACPI / utils: Drop reference in test for device presence |
| |
| [ Upstream commit 54e3aca84e571559915998aa6cc05e5ac37c043b ] |
| |
| When commit 8661423eea1a ("ACPI / utils: Add new acpi_dev_present |
| helper") introduced acpi_dev_present(), it missed the fact that |
| bus_find_device() took a reference on the device found by it and |
| the callers of acpi_dev_present() don't drop that reference. |
| |
| Drop the reference on the device in acpi_dev_present(). |
| |
| Fixes: 8661423eea1a ("ACPI / utils: Add new acpi_dev_present helper") |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Reviewed-by: Hans de Goede <hdegoede@redhat.com> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/acpi/utils.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c |
| index 78db97687f26..c4b06cc075f9 100644 |
| --- a/drivers/acpi/utils.c |
| +++ b/drivers/acpi/utils.c |
| @@ -800,6 +800,7 @@ bool acpi_dev_present(const char *hid, const char *uid, s64 hrv) |
| match.hrv = hrv; |
| |
| dev = bus_find_device(&acpi_bus_type, NULL, &match, acpi_dev_match_cb); |
| + put_device(dev); |
| return !!dev; |
| } |
| EXPORT_SYMBOL(acpi_dev_present); |
| -- |
| 2.19.1 |
| |
