| From foo@baz Fri 31 May 2019 03:21:27 PM PDT |
| From: Jisheng Zhang <Jisheng.Zhang@synaptics.com> |
| Date: Wed, 22 May 2019 10:05:09 +0000 |
| Subject: net: stmmac: fix reset gpio free missing |
| |
| From: Jisheng Zhang <Jisheng.Zhang@synaptics.com> |
| |
| [ Upstream commit 49ce881c0d4c4a7a35358d9dccd5f26d0e56fc61 ] |
| |
| Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") |
| removed the reset gpio free, when the driver is unbinded or rmmod, |
| we miss the gpio free. |
| |
| This patch uses managed API to request the reset gpio, so that the |
| gpio could be freed properly. |
| |
| Fixes: 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") |
| Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c |
| +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c |
| @@ -267,7 +267,8 @@ int stmmac_mdio_reset(struct mii_bus *bu |
| of_property_read_u32_array(np, |
| "snps,reset-delays-us", data->delays, 3); |
| |
| - if (gpio_request(data->reset_gpio, "mdio-reset")) |
| + if (devm_gpio_request(priv->device, data->reset_gpio, |
| + "mdio-reset")) |
| return 0; |
| } |
| |
