| From e4a0377a0d4a22497b6344ccd28bc9e6b6b1820a Mon Sep 17 00:00:00 2001 |
| From: YueHaibing <yuehaibing@huawei.com> |
| Date: Wed, 31 Jul 2019 20:38:14 +0800 |
| Subject: gpio: Fix build error of function redefinition |
| |
| [ Upstream commit 68e03b85474a51ec1921b4d13204782594ef7223 ] |
| |
| when do randbuilding, I got this error: |
| |
| In file included from drivers/hwmon/pmbus/ucd9000.c:19:0: |
| ./include/linux/gpio/driver.h:576:1: error: redefinition of gpiochip_add_pin_range |
| gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, |
| ^~~~~~~~~~~~~~~~~~~~~~ |
| In file included from drivers/hwmon/pmbus/ucd9000.c:18:0: |
| ./include/linux/gpio.h:245:1: note: previous definition of gpiochip_add_pin_range was here |
| gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, |
| ^~~~~~~~~~~~~~~~~~~~~~ |
| |
| Reported-by: Hulk Robot <hulkci@huawei.com> |
| Fixes: 964cb341882f ("gpio: move pincontrol calls to <linux/gpio/driver.h>") |
| Signed-off-by: YueHaibing <yuehaibing@huawei.com> |
| Link: https://lore.kernel.org/r/20190731123814.46624-1-yuehaibing@huawei.com |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| include/linux/gpio.h | 24 ------------------------ |
| 1 file changed, 24 deletions(-) |
| |
| diff --git a/include/linux/gpio.h b/include/linux/gpio.h |
| index d12b5d566e4b1..11555bd821b73 100644 |
| --- a/include/linux/gpio.h |
| +++ b/include/linux/gpio.h |
| @@ -229,30 +229,6 @@ static inline int irq_to_gpio(unsigned irq) |
| return -EINVAL; |
| } |
| |
| -static inline int |
| -gpiochip_add_pin_range(struct gpio_chip *chip, const char *pinctl_name, |
| - unsigned int gpio_offset, unsigned int pin_offset, |
| - unsigned int npins) |
| -{ |
| - WARN_ON(1); |
| - return -EINVAL; |
| -} |
| - |
| -static inline int |
| -gpiochip_add_pingroup_range(struct gpio_chip *chip, |
| - struct pinctrl_dev *pctldev, |
| - unsigned int gpio_offset, const char *pin_group) |
| -{ |
| - WARN_ON(1); |
| - return -EINVAL; |
| -} |
| - |
| -static inline void |
| -gpiochip_remove_pin_ranges(struct gpio_chip *chip) |
| -{ |
| - WARN_ON(1); |
| -} |
| - |
| static inline int devm_gpio_request(struct device *dev, unsigned gpio, |
| const char *label) |
| { |
| -- |
| 2.20.1 |
| |