| From a7a1ab183ca80b81ed7f70892a88167e74ad3588 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 4 Oct 2018 00:52:52 +0200 |
| Subject: gpio: syscon: Fix possible NULL ptr usage |
| |
| From: Marek Vasut <marex@denx.de> |
| |
| [ Upstream commit 70728c29465bc4bfa7a8c14304771eab77e923c7 ] |
| |
| The priv->data->set can be NULL while flags contains GPIO_SYSCON_FEAT_OUT |
| and chip->set is valid pointer. This happens in case the controller uses |
| the default GPIO setter. Always use chip->set to access the setter to avoid |
| possible NULL pointer dereferencing. |
| |
| Signed-off-by: Marek Vasut <marex@denx.de> |
| Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpio/gpio-syscon.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c |
| index 537cec7583fca..cf88a0bfe99ea 100644 |
| --- a/drivers/gpio/gpio-syscon.c |
| +++ b/drivers/gpio/gpio-syscon.c |
| @@ -122,7 +122,7 @@ static int syscon_gpio_dir_out(struct gpio_chip *chip, unsigned offset, int val) |
| BIT(offs % SYSCON_REG_BITS)); |
| } |
| |
| - priv->data->set(chip, offset, val); |
| + chip->set(chip, offset, val); |
| |
| return 0; |
| } |
| -- |
| 2.20.1 |
| |
