| From 4cdf1d2a816a93fa02f7b6b5492dc7f55af2a199 Mon Sep 17 00:00:00 2001 |
| From: Chenyuan Yang <chenyuan0y@gmail.com> |
| Date: Mon, 24 Feb 2025 17:37:36 -0600 |
| Subject: mfd: ene-kb3930: Fix a potential NULL pointer dereference |
| |
| From: Chenyuan Yang <chenyuan0y@gmail.com> |
| |
| commit 4cdf1d2a816a93fa02f7b6b5492dc7f55af2a199 upstream. |
| |
| The off_gpios could be NULL. Add missing check in the kb3930_probe(). |
| This is similar to the issue fixed in commit b1ba8bcb2d1f |
| ("backlight: hx8357: Fix potential NULL pointer dereference"). |
| |
| This was detected by our static analysis tool. |
| |
| Cc: stable@vger.kernel.org |
| Fixes: ede6b2d1dfc0 ("mfd: ene-kb3930: Add driver for ENE KB3930 Embedded Controller") |
| Suggested-by: Lee Jones <lee@kernel.org> |
| Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com> |
| Link: https://lore.kernel.org/r/20250224233736.1919739-1-chenyuan0y@gmail.com |
| Signed-off-by: Lee Jones <lee@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/mfd/ene-kb3930.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/mfd/ene-kb3930.c |
| +++ b/drivers/mfd/ene-kb3930.c |
| @@ -162,7 +162,7 @@ static int kb3930_probe(struct i2c_clien |
| devm_gpiod_get_array_optional(dev, "off", GPIOD_IN); |
| if (IS_ERR(ddata->off_gpios)) |
| return PTR_ERR(ddata->off_gpios); |
| - if (ddata->off_gpios->ndescs < 2) { |
| + if (ddata->off_gpios && ddata->off_gpios->ndescs < 2) { |
| dev_err(dev, "invalid off-gpios property\n"); |
| return -EINVAL; |
| } |
