| From 082b86919b7a94de01d849021b4da820a6cb89dc Mon Sep 17 00:00:00 2001 |
| From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Date: Wed, 8 Oct 2025 12:55:18 +0300 |
| Subject: media: v4l2-mem2mem: Fix outdated documentation |
| |
| From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| |
| commit 082b86919b7a94de01d849021b4da820a6cb89dc upstream. |
| |
| Commit cbd9463da1b1 ("media: v4l2-mem2mem: Avoid calling .device_run in |
| v4l2_m2m_job_finish") deferred calls to .device_run() to a work queue to |
| avoid recursive calls when a job is finished right away from |
| .device_run(). It failed to update the v4l2_m2m_job_finish() |
| documentation that still states the function must not be called from |
| .device_run(). Fix it. |
| |
| Fixes: cbd9463da1b1 ("media: v4l2-mem2mem: Avoid calling .device_run in v4l2_m2m_job_finish") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> |
| Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| include/media/v4l2-mem2mem.h | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| --- a/include/media/v4l2-mem2mem.h |
| +++ b/include/media/v4l2-mem2mem.h |
| @@ -185,8 +185,7 @@ void v4l2_m2m_try_schedule(struct v4l2_m |
| * other instances to take control of the device. |
| * |
| * This function has to be called only after &v4l2_m2m_ops->device_run |
| - * callback has been called on the driver. To prevent recursion, it should |
| - * not be called directly from the &v4l2_m2m_ops->device_run callback though. |
| + * callback has been called on the driver. |
| */ |
| void v4l2_m2m_job_finish(struct v4l2_m2m_dev *m2m_dev, |
| struct v4l2_m2m_ctx *m2m_ctx); |
