| From 347c958c679747b697d04c009f3f5b177f859620 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 31 Mar 2021 14:17:06 -0700 |
| Subject: ice: fix clang warning regarding deadcode.DeadStores |
| |
| From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> |
| |
| [ Upstream commit 7e94090ae13e1ae5fe8bd3a9cd08136260bb7039 ] |
| |
| clang generates deadcode.DeadStores warnings when a variable |
| is used to read a value, but then that value isn't used later |
| in the code. Fix this warning. |
| |
| Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> |
| Tested-by: Tony Brelinski <tonyx.brelinski@intel.com> |
| Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/intel/ice/ice_ethtool.c | 6 +----- |
| 1 file changed, 1 insertion(+), 5 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/intel/ice/ice_ethtool.c b/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| index a7975afecf70..14eba9bc174d 100644 |
| --- a/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| +++ b/drivers/net/ethernet/intel/ice/ice_ethtool.c |
| @@ -3492,13 +3492,9 @@ static int |
| ice_get_rc_coalesce(struct ethtool_coalesce *ec, enum ice_container_type c_type, |
| struct ice_ring_container *rc) |
| { |
| - struct ice_pf *pf; |
| - |
| if (!rc->ring) |
| return -EINVAL; |
| |
| - pf = rc->ring->vsi->back; |
| - |
| switch (c_type) { |
| case ICE_RX_CONTAINER: |
| ec->use_adaptive_rx_coalesce = ITR_IS_DYNAMIC(rc->itr_setting); |
| @@ -3510,7 +3506,7 @@ ice_get_rc_coalesce(struct ethtool_coalesce *ec, enum ice_container_type c_type, |
| ec->tx_coalesce_usecs = rc->itr_setting & ~ICE_ITR_DYNAMIC; |
| break; |
| default: |
| - dev_dbg(ice_pf_to_dev(pf), "Invalid c_type %d\n", c_type); |
| + dev_dbg(ice_pf_to_dev(rc->ring->vsi->back), "Invalid c_type %d\n", c_type); |
| return -EINVAL; |
| } |
| |
| -- |
| 2.30.2 |
| |
