| From 302df27bc041115ff2bb90ece4d09bf5acaa8a90 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 28 Apr 2021 14:58:07 +0200 |
| Subject: arm64: dts: ls208xa: remove bus-num from dspi node |
| |
| From: Mian Yousaf Kaukab <ykaukab@suse.de> |
| |
| [ Upstream commit 8240c972c1798ea013cbb407722295fc826b3584 ] |
| |
| On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module |
| then its probe fails with the following warning: |
| |
| [ 10.471363] couldn't get idr |
| [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0 |
| ... |
| [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr |
| [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16 |
| |
| Reason for the failure is that bus-num property is set for dspi node. |
| However, bus-num property is not set for the qspi node. If probe for |
| spi-fsl-qspi happens first then id 0 is dynamically allocated to it. |
| Call to spi_register_controller() from spi-fsl-dspi driver then fails. |
| Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property |
| optional") bus-num property is optional. Remove bus-num property from |
| dspi node to fix the issue. |
| |
| Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de> |
| Signed-off-by: Shawn Guo <shawnguo@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 - |
| 1 file changed, 1 deletion(-) |
| |
| diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi |
| index e7abb74bd816..4d34d82b898a 100644 |
| --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi |
| +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi |
| @@ -625,7 +625,6 @@ |
| clocks = <&clockgen 4 3>; |
| clock-names = "dspi"; |
| spi-num-chipselects = <5>; |
| - bus-num = <0>; |
| }; |
| |
| esdhc: esdhc@2140000 { |
| -- |
| 2.30.2 |
| |
