| From e790de54e94a7a15fb725b34724d41d41cbaa60c Mon Sep 17 00:00:00 2001 |
| From: Varun Prakash <varun@chelsio.com> |
| Date: Mon, 25 Oct 2021 22:46:54 +0530 |
| Subject: nvmet-tcp: fix data digest pointer calculation |
| |
| From: Varun Prakash <varun@chelsio.com> |
| |
| commit e790de54e94a7a15fb725b34724d41d41cbaa60c upstream. |
| |
| exp_ddgst is of type __le32, &cmd->exp_ddgst + cmd->offset increases |
| &cmd->exp_ddgst by 4 * cmd->offset, fix this by type casting |
| &cmd->exp_ddgst to u8 *. |
| |
| Fixes: 872d26a391da ("nvmet-tcp: add NVMe over TCP target driver") |
| Signed-off-by: Varun Prakash <varun@chelsio.com> |
| Reviewed-by: Sagi Grimberg <sagi@grimberg.me> |
| Signed-off-by: Christoph Hellwig <hch@lst.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/nvme/target/tcp.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/nvme/target/tcp.c |
| +++ b/drivers/nvme/target/tcp.c |
| @@ -702,7 +702,7 @@ static int nvmet_try_send_ddgst(struct n |
| struct nvmet_tcp_queue *queue = cmd->queue; |
| struct msghdr msg = { .msg_flags = MSG_DONTWAIT }; |
| struct kvec iov = { |
| - .iov_base = &cmd->exp_ddgst + cmd->offset, |
| + .iov_base = (u8 *)&cmd->exp_ddgst + cmd->offset, |
| .iov_len = NVME_TCP_DIGEST_LENGTH - cmd->offset |
| }; |
| int ret; |