| From e9fdcb3d3765adb7138cf925f31bcef2368d1745 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 26 Jul 2022 18:15:31 +0300 |
| Subject: drm/amd/display: fix signedness bug in execute_synaptics_rc_command() |
| |
| From: Dan Carpenter <dan.carpenter@oracle.com> |
| |
| [ Upstream commit 06ac561fb0edf868f7b292fb4a3c8ffbbb1e14bb ] |
| |
| The "ret" variable needs to be signed for the error handling to work. |
| |
| Fixes: 2ca97adccdc9 ("drm/amd/display: Add Synaptics Fifo Reset Workaround") |
| Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c |
| index f5f39984702f..a3282ddbff86 100644 |
| --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c |
| +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c |
| @@ -571,7 +571,7 @@ static bool execute_synaptics_rc_command(struct drm_dp_aux *aux, |
| unsigned char rc_cmd = 0; |
| unsigned char rc_result = 0xFF; |
| unsigned char i = 0; |
| - uint8_t ret = 0; |
| + int ret; |
| |
| if (is_write_cmd) { |
| // write rc data |
| -- |
| 2.35.1 |
| |
