| From 4e3bbd5ba8dfccb165f259c98afaf5ac8644bd46 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 26 Aug 2019 17:14:36 +0200 |
| Subject: PCI: Use static const struct, not const static struct |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Krzysztof Wilczynski <kw@linux.com> |
| |
| [ Upstream commit 8050f3f6645ae0f7e4c1304593f6f7eb2ee7d85c ] |
| |
| Move the static keyword to the front of declarations of pci_regs_behavior[] |
| and pcie_cap_regs_behavior[], which resolves compiler warnings when |
| building with "W=1": |
| |
| drivers/pci/pci-bridge-emul.c:41:1: warning: ‘static’ is not at beginning of |
| declaration [-Wold-style-declaration] |
| const static struct pci_bridge_reg_behavior pci_regs_behavior[] = { |
| ^ |
| drivers/pci/pci-bridge-emul.c:176:1: warning: ‘static’ is not at beginning of |
| declaration [-Wold-style-declaration] |
| const static struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = { |
| ^ |
| |
| Link: https://lore.kernel.org/r/20190826151436.4672-1-kw@linux.com |
| Link: https://lore.kernel.org/r/20190828131733.5817-1-kw@linux.com |
| Signed-off-by: Krzysztof Wilczynski <kw@linux.com> |
| Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> |
| Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pci/pci-bridge-emul.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci-bridge-emul.c |
| index 83fb077d0b41f..702966e4fcaa4 100644 |
| --- a/drivers/pci/pci-bridge-emul.c |
| +++ b/drivers/pci/pci-bridge-emul.c |
| @@ -38,7 +38,7 @@ struct pci_bridge_reg_behavior { |
| u32 rsvd; |
| }; |
| |
| -const static struct pci_bridge_reg_behavior pci_regs_behavior[] = { |
| +static const struct pci_bridge_reg_behavior pci_regs_behavior[] = { |
| [PCI_VENDOR_ID / 4] = { .ro = ~0 }, |
| [PCI_COMMAND / 4] = { |
| .rw = (PCI_COMMAND_IO | PCI_COMMAND_MEMORY | |
| @@ -173,7 +173,7 @@ const static struct pci_bridge_reg_behavior pci_regs_behavior[] = { |
| }, |
| }; |
| |
| -const static struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = { |
| +static const struct pci_bridge_reg_behavior pcie_cap_regs_behavior[] = { |
| [PCI_CAP_LIST_ID / 4] = { |
| /* |
| * Capability ID, Next Capability Pointer and |
| -- |
| 2.20.1 |
| |