| From 79607556b89ecc4d77cfd6256f8c8171f3a9daad Mon Sep 17 00:00:00 2001 |
| From: Fabio Estevam <festevam@gmail.com> |
| Date: Thu, 6 Jun 2019 09:40:33 -0300 |
| Subject: net: fec: Do not use netdev messages too early |
| |
| [ Upstream commit a19a0582363b9a5f8ba812f34f1b8df394898780 ] |
| |
| When a valid MAC address is not found the current messages |
| are shown: |
| |
| fec 2188000.ethernet (unnamed net_device) (uninitialized): Invalid MAC address: 00:00:00:00:00:00 |
| fec 2188000.ethernet (unnamed net_device) (uninitialized): Using random MAC address: aa:9f:25:eb:7e:aa |
| |
| Since the network device has not been registered at this point, it is better |
| to use dev_err()/dev_info() instead, which will provide cleaner log |
| messages like these: |
| |
| fec 2188000.ethernet: Invalid MAC address: 00:00:00:00:00:00 |
| fec 2188000.ethernet: Using random MAC address: aa:9f:25:eb:7e:aa |
| |
| Tested on a imx6dl-pico-pi board. |
| |
| Signed-off-by: Fabio Estevam <festevam@gmail.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/freescale/fec_main.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c |
| index 38f10f7dcbc3..831bb709e783 100644 |
| --- a/drivers/net/ethernet/freescale/fec_main.c |
| +++ b/drivers/net/ethernet/freescale/fec_main.c |
| @@ -1689,10 +1689,10 @@ static void fec_get_mac(struct net_device *ndev) |
| */ |
| if (!is_valid_ether_addr(iap)) { |
| /* Report it and use a random ethernet address instead */ |
| - netdev_err(ndev, "Invalid MAC address: %pM\n", iap); |
| + dev_err(&fep->pdev->dev, "Invalid MAC address: %pM\n", iap); |
| eth_hw_addr_random(ndev); |
| - netdev_info(ndev, "Using random MAC address: %pM\n", |
| - ndev->dev_addr); |
| + dev_info(&fep->pdev->dev, "Using random MAC address: %pM\n", |
| + ndev->dev_addr); |
| return; |
| } |
| |
| -- |
| 2.20.1 |
| |
