| From 9c1f2a8b45a29c947f25cbab503650f340c913cd Mon Sep 17 00:00:00 2001 |
| From: Hechao Li <hechaol@fb.com> |
| Date: Mon, 10 Jun 2019 17:43:07 -0700 |
| Subject: selftests/bpf : clean up feature/ when make clean |
| |
| [ Upstream commit 89cceaa939171fafa153d4bf637b39e396bbd785 ] |
| |
| An error "implicit declaration of function 'reallocarray'" can be thrown |
| with the following steps: |
| |
| $ cd tools/testing/selftests/bpf |
| $ make clean && make CC=<Path to GCC 4.8.5> |
| $ make clean && make CC=<Path to GCC 7.x> |
| |
| The cause is that the feature folder generated by GCC 4.8.5 is not |
| removed, leaving feature-reallocarray being 1, which causes reallocarray |
| not defined when re-compliing with GCC 7.x. This diff adds feature |
| folder to EXTRA_CLEAN to avoid this problem. |
| |
| v2: Rephrase the commit message. |
| |
| Signed-off-by: Hechao Li <hechaol@fb.com> |
| Acked-by: Andrii Nakryiko <andriin@fb.com> |
| Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/testing/selftests/bpf/Makefile | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile |
| index e36356e2377e..1c9511262947 100644 |
| --- a/tools/testing/selftests/bpf/Makefile |
| +++ b/tools/testing/selftests/bpf/Makefile |
| @@ -275,4 +275,5 @@ $(OUTPUT)/verifier/tests.h: $(VERIFIER_TESTS_DIR) $(VERIFIER_TEST_FILES) |
| ) > $(VERIFIER_TESTS_H)) |
| |
| EXTRA_CLEAN := $(TEST_CUSTOM_PROGS) $(ALU32_BUILD_DIR) \ |
| - $(VERIFIER_TESTS_H) $(PROG_TESTS_H) $(MAP_TESTS_H) |
| + $(VERIFIER_TESTS_H) $(PROG_TESTS_H) $(MAP_TESTS_H) \ |
| + feature |
| -- |
| 2.20.1 |
| |
