| From ccd61312d80450e60121c4b771244abeeaf32edc Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 27 Sep 2019 11:47:08 +0200 |
| Subject: fbdev: c2p: Fix link failure on non-inlining |
| |
| From: Geert Uytterhoeven <geert@linux-m68k.org> |
| |
| [ Upstream commit b330f3972f4f2a829d41fb9e9b552bec7d73a840 ] |
| |
| When the compiler decides not to inline the Chunky-to-Planar core |
| functions, the build fails with: |
| |
| c2p_planar.c:(.text+0xd6): undefined reference to `c2p_unsupported' |
| c2p_planar.c:(.text+0x1dc): undefined reference to `c2p_unsupported' |
| c2p_iplan2.c:(.text+0xc4): undefined reference to `c2p_unsupported' |
| c2p_iplan2.c:(.text+0x150): undefined reference to `c2p_unsupported' |
| |
| Fix this by marking the functions __always_inline. |
| |
| While this could be triggered before by manually enabling both |
| CONFIG_OPTIMIZE_INLINING and CONFIG_CC_OPTIMIZE_FOR_SIZE, it was exposed |
| in the m68k defconfig by commit ac7c3e4ff401b304 ("compiler: enable |
| CONFIG_OPTIMIZE_INLINING forcibly"). |
| |
| Fixes: 9012d011660ea5cf ("compiler: allow all arches to enable CONFIG_OPTIMIZE_INLINING") |
| Reported-by: noreply@ellerman.id.au |
| Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> |
| Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com> |
| Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20190927094708.11563-1-geert@linux-m68k.org |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/video/fbdev/c2p_core.h | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/video/fbdev/c2p_core.h b/drivers/video/fbdev/c2p_core.h |
| index e1035a865fb94..45a6d895a7d72 100644 |
| --- a/drivers/video/fbdev/c2p_core.h |
| +++ b/drivers/video/fbdev/c2p_core.h |
| @@ -29,7 +29,7 @@ static inline void _transp(u32 d[], unsigned int i1, unsigned int i2, |
| |
| extern void c2p_unsupported(void); |
| |
| -static inline u32 get_mask(unsigned int n) |
| +static __always_inline u32 get_mask(unsigned int n) |
| { |
| switch (n) { |
| case 1: |
| @@ -57,7 +57,7 @@ static inline u32 get_mask(unsigned int n) |
| * Transpose operations on 8 32-bit words |
| */ |
| |
| -static inline void transp8(u32 d[], unsigned int n, unsigned int m) |
| +static __always_inline void transp8(u32 d[], unsigned int n, unsigned int m) |
| { |
| u32 mask = get_mask(n); |
| |
| @@ -99,7 +99,7 @@ static inline void transp8(u32 d[], unsigned int n, unsigned int m) |
| * Transpose operations on 4 32-bit words |
| */ |
| |
| -static inline void transp4(u32 d[], unsigned int n, unsigned int m) |
| +static __always_inline void transp4(u32 d[], unsigned int n, unsigned int m) |
| { |
| u32 mask = get_mask(n); |
| |
| @@ -126,7 +126,7 @@ static inline void transp4(u32 d[], unsigned int n, unsigned int m) |
| * Transpose operations on 4 32-bit words (reverse order) |
| */ |
| |
| -static inline void transp4x(u32 d[], unsigned int n, unsigned int m) |
| +static __always_inline void transp4x(u32 d[], unsigned int n, unsigned int m) |
| { |
| u32 mask = get_mask(n); |
| |
| -- |
| 2.20.1 |
| |