| From 3005a81265267bcf2d1d331d5c3c0f2c992f84e3 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 27 Jan 2022 08:00:59 +0800 |
| Subject: scsi: mvsas: Replace snprintf() with sysfs_emit() |
| |
| From: Yang Guang <yang.guang5@zte.com.cn> |
| |
| [ Upstream commit 0ad3867b0f13e45cfee5a1298bfd40eef096116c ] |
| |
| coccinelle report: |
| ./drivers/scsi/mvsas/mv_init.c:699:8-16: |
| WARNING: use scnprintf or sprintf |
| ./drivers/scsi/mvsas/mv_init.c:747:8-16: |
| WARNING: use scnprintf or sprintf |
| |
| Use sysfs_emit() instead of scnprintf() or sprintf(). |
| |
| Link: https://lore.kernel.org/r/c1711f7cf251730a8ceb5bdfc313bf85662b3395.1643182948.git.yang.guang5@zte.com.cn |
| Reported-by: Zeal Robot <zealci@zte.com.cn> |
| Signed-off-by: Yang Guang <yang.guang5@zte.com.cn> |
| Signed-off-by: David Yang <davidcomponentone@gmail.com> |
| Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/scsi/mvsas/mv_init.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c |
| index 52405ce58ade..c16d7fb0fdcb 100644 |
| --- a/drivers/scsi/mvsas/mv_init.c |
| +++ b/drivers/scsi/mvsas/mv_init.c |
| @@ -697,7 +697,7 @@ static ssize_t |
| mvs_show_driver_version(struct device *cdev, |
| struct device_attribute *attr, char *buffer) |
| { |
| - return snprintf(buffer, PAGE_SIZE, "%s\n", DRV_VERSION); |
| + return sysfs_emit(buffer, "%s\n", DRV_VERSION); |
| } |
| |
| static DEVICE_ATTR(driver_version, |
| @@ -749,7 +749,7 @@ mvs_store_interrupt_coalescing(struct device *cdev, |
| static ssize_t mvs_show_interrupt_coalescing(struct device *cdev, |
| struct device_attribute *attr, char *buffer) |
| { |
| - return snprintf(buffer, PAGE_SIZE, "%d\n", interrupt_coalescing); |
| + return sysfs_emit(buffer, "%d\n", interrupt_coalescing); |
| } |
| |
| static DEVICE_ATTR(interrupt_coalescing, |
| -- |
| 2.35.1 |
| |
