| From b6bd0af2bd429e157690cd6e3e9e08a6c91ecafa Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 15 Sep 2022 18:59:12 -0400 |
| Subject: WRITE is "data source", not destination... |
| |
| From: Al Viro <viro@zeniv.linux.org.uk> |
| |
| [ Upstream commit 974c36fb828aeae7b4f9063f94860ae6c5633efd ] |
| |
| Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/fsi/fsi-sbefifo.c | 6 +++--- |
| 1 file changed, 3 insertions(+), 3 deletions(-) |
| |
| diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c |
| index c8ccc99e214f..84a60d2d8e8a 100644 |
| --- a/drivers/fsi/fsi-sbefifo.c |
| +++ b/drivers/fsi/fsi-sbefifo.c |
| @@ -640,7 +640,7 @@ static void sbefifo_collect_async_ffdc(struct sbefifo *sbefifo) |
| } |
| ffdc_iov.iov_base = ffdc; |
| ffdc_iov.iov_len = SBEFIFO_MAX_FFDC_SIZE; |
| - iov_iter_kvec(&ffdc_iter, WRITE, &ffdc_iov, 1, SBEFIFO_MAX_FFDC_SIZE); |
| + iov_iter_kvec(&ffdc_iter, READ, &ffdc_iov, 1, SBEFIFO_MAX_FFDC_SIZE); |
| cmd[0] = cpu_to_be32(2); |
| cmd[1] = cpu_to_be32(SBEFIFO_CMD_GET_SBE_FFDC); |
| rc = sbefifo_do_command(sbefifo, cmd, 2, &ffdc_iter); |
| @@ -737,7 +737,7 @@ int sbefifo_submit(struct device *dev, const __be32 *command, size_t cmd_len, |
| rbytes = (*resp_len) * sizeof(__be32); |
| resp_iov.iov_base = response; |
| resp_iov.iov_len = rbytes; |
| - iov_iter_kvec(&resp_iter, WRITE, &resp_iov, 1, rbytes); |
| + iov_iter_kvec(&resp_iter, READ, &resp_iov, 1, rbytes); |
| |
| /* Perform the command */ |
| mutex_lock(&sbefifo->lock); |
| @@ -817,7 +817,7 @@ static ssize_t sbefifo_user_read(struct file *file, char __user *buf, |
| /* Prepare iov iterator */ |
| resp_iov.iov_base = buf; |
| resp_iov.iov_len = len; |
| - iov_iter_init(&resp_iter, WRITE, &resp_iov, 1, len); |
| + iov_iter_init(&resp_iter, READ, &resp_iov, 1, len); |
| |
| /* Perform the command */ |
| mutex_lock(&sbefifo->lock); |
| -- |
| 2.39.0 |
| |
