| From 992bdddaabfba19bdc77c1c7a4977b2aa41ec891 Mon Sep 17 00:00:00 2001 |
| From: Thomas Zimmermann <tzimmermann@suse.de> |
| Date: Tue, 13 Jun 2023 13:06:36 +0200 |
| Subject: backlight/bd6107: Compare against struct fb_info.device |
| |
| From: Thomas Zimmermann <tzimmermann@suse.de> |
| |
| commit 992bdddaabfba19bdc77c1c7a4977b2aa41ec891 upstream. |
| |
| Struct bd6107_platform_data refers to a platform device within |
| the Linux device hierarchy. The test in bd6107_backlight_check_fb() |
| compares it against the fbdev device in struct fb_info.dev, which |
| is different. Fix the test by comparing to struct fb_info.device. |
| |
| Fixes a bug in the backlight driver and prepares fbdev for making |
| struct fb_info.dev optional. |
| |
| v2: |
| * move renames into separate patch (Javier, Sam, Michael) |
| |
| Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver") |
| Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> |
| Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> |
| Cc: Lee Jones <lee@kernel.org> |
| Cc: Daniel Thompson <daniel.thompson@linaro.org> |
| Cc: Jingoo Han <jingoohan1@gmail.com> |
| Cc: dri-devel@lists.freedesktop.org |
| Cc: <stable@vger.kernel.org> # v3.12+ |
| Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> |
| Reviewed-by: Sam Ravnborg <sam@ravnborg.org> |
| Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20230613110953.24176-2-tzimmermann@suse.de |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/video/backlight/bd6107.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/video/backlight/bd6107.c |
| +++ b/drivers/video/backlight/bd6107.c |
| @@ -107,7 +107,7 @@ static int bd6107_backlight_check_fb(str |
| { |
| struct bd6107 *bd = bl_get_data(backlight); |
| |
| - return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->dev; |
| + return bd->pdata->fbdev == NULL || bd->pdata->fbdev == info->device; |
| } |
| |
| static const struct backlight_ops bd6107_backlight_ops = { |
