| From 92a78a83c87ce82c463f59f2641d86270d350303 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 Mar 2025 20:27:05 -0500 |
| Subject: usb: gadget: aspeed: Add NULL pointer check in ast_vhub_init_dev() |
| |
| From: Chenyuan Yang <chenyuan0y@gmail.com> |
| |
| [ Upstream commit 8c75f3e6a433d92084ad4e78b029ae680865420f ] |
| |
| The variable d->name, returned by devm_kasprintf(), could be NULL. |
| A pointer check is added to prevent potential NULL pointer dereference. |
| This is similar to the fix in commit 3027e7b15b02 |
| ("ice: Fix some null pointer dereference issues in ice_ptp.c"). |
| |
| This issue is found by our static analysis tool |
| |
| Signed-off-by: Chenyuan Yang <chenyuan0y@gmail.com> |
| Link: https://lore.kernel.org/r/20250311012705.1233829-1-chenyuan0y@gmail.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/usb/gadget/udc/aspeed-vhub/dev.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| diff --git a/drivers/usb/gadget/udc/aspeed-vhub/dev.c b/drivers/usb/gadget/udc/aspeed-vhub/dev.c |
| index 4008e7a511889..89d7d3b24718d 100644 |
| --- a/drivers/usb/gadget/udc/aspeed-vhub/dev.c |
| +++ b/drivers/usb/gadget/udc/aspeed-vhub/dev.c |
| @@ -542,6 +542,9 @@ int ast_vhub_init_dev(struct ast_vhub *vhub, unsigned int idx) |
| d->vhub = vhub; |
| d->index = idx; |
| d->name = devm_kasprintf(parent, GFP_KERNEL, "port%d", idx+1); |
| + if (!d->name) |
| + return -ENOMEM; |
| + |
| d->regs = vhub->regs + 0x100 + 0x10 * idx; |
| |
| ast_vhub_init_ep0(vhub, &d->ep0, d); |
| -- |
| 2.39.5 |
| |
