| From de17cade0e034e9b721a6db9b488014effac1e5a Mon Sep 17 00:00:00 2001 |
| From: Miquel Raynal <miquel.raynal@bootlin.com> |
| Date: Tue, 19 May 2020 14:59:54 +0200 |
| Subject: mtd: rawnand: ingenic: Fix the probe error path |
| |
| From: Miquel Raynal <miquel.raynal@bootlin.com> |
| |
| commit de17cade0e034e9b721a6db9b488014effac1e5a upstream. |
| |
| nand_release() is supposed be called after MTD device registration. |
| Here, only nand_scan() happened, so use nand_cleanup() instead. |
| |
| There is no real Fixes tag applying here as the use of nand_release() |
| in this driver predates the introduction of nand_cleanup() in |
| commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") |
| which makes this change possible. Hence, pointing it as the commit to |
| fix for backporting purposes, even if this commit is not introducing |
| any bug makes sense. |
| |
| Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") |
| Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> |
| Cc: stable@vger.kernel.org |
| Cc: Paul Cercueil <paul@crapouillou.net> |
| Cc: Harvey Hunt <harveyhuntnexus@gmail.com> |
| Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-22-miquel.raynal@bootlin.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c |
| +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c |
| @@ -376,7 +376,7 @@ static int ingenic_nand_init_chip(struct |
| |
| ret = mtd_device_register(mtd, NULL, 0); |
| if (ret) { |
| - nand_release(chip); |
| + nand_cleanup(chip); |
| return ret; |
| } |
| |
