| From 9d779a68a89614f61d7795a6a03b3cf510a7dae8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 25 Feb 2025 09:26:08 +0200 |
| Subject: net/mlx5: IRQ, Fix null string in debug print |
| |
| From: Shay Drory <shayd@nvidia.com> |
| |
| [ Upstream commit 2f5a6014eb168a97b24153adccfa663d3b282767 ] |
| |
| irq_pool_alloc() debug print can print a null string. |
| Fix it by providing a default string to print. |
| |
| Fixes: 71e084e26414 ("net/mlx5: Allocating a pool of MSI-X vectors for SFs") |
| Signed-off-by: Shay Drory <shayd@nvidia.com> |
| Reported-by: kernel test robot <lkp@intel.com> |
| Closes: https://lore.kernel.org/oe-kbuild-all/202501141055.SwfIphN0-lkp@intel.com/ |
| Reviewed-by: Moshe Shemesh <moshe@nvidia.com> |
| Signed-off-by: Tariq Toukan <tariqt@nvidia.com> |
| Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com> |
| Link: https://patch.msgid.link/20250225072608.526866-4-tariqt@nvidia.com |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c |
| index a6d3fc96e1685..10b9dc2aaf06f 100644 |
| --- a/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c |
| +++ b/drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c |
| @@ -513,7 +513,7 @@ irq_pool_alloc(struct mlx5_core_dev *dev, int start, int size, char *name, |
| pool->min_threshold = min_threshold * MLX5_EQ_REFS_PER_IRQ; |
| pool->max_threshold = max_threshold * MLX5_EQ_REFS_PER_IRQ; |
| mlx5_core_dbg(dev, "pool->name = %s, pool->size = %d, pool->start = %d", |
| - name, size, start); |
| + name ? name : "mlx5_pcif_pool", size, start); |
| return pool; |
| } |
| |
| -- |
| 2.39.5 |
| |
