| From 6637415ab8ed69a50aef3247f215d85de25d32cd Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 27 Nov 2023 17:26:29 -0500 |
| Subject: drm/amdgpu/debugfs: fix error code when smc register accessors are |
| NULL |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Alex Deucher <alexander.deucher@amd.com> |
| |
| [ Upstream commit afe58346d5d3887b3e49ff623d2f2e471f232a8d ] |
| |
| Should be -EOPNOTSUPP. |
| |
| Fixes: 5104fdf50d32 ("drm/amdgpu: Fix a null pointer access when the smc_rreg pointer is NULL") |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| index 8123feb1a116..06ab6066da61 100644 |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| @@ -596,7 +596,7 @@ static ssize_t amdgpu_debugfs_regs_smc_read(struct file *f, char __user *buf, |
| int r; |
| |
| if (!adev->smc_rreg) |
| - return -EPERM; |
| + return -EOPNOTSUPP; |
| |
| if (size & 0x3 || *pos & 0x3) |
| return -EINVAL; |
| @@ -655,7 +655,7 @@ static ssize_t amdgpu_debugfs_regs_smc_write(struct file *f, const char __user * |
| int r; |
| |
| if (!adev->smc_wreg) |
| - return -EPERM; |
| + return -EOPNOTSUPP; |
| |
| if (size & 0x3 || *pos & 0x3) |
| return -EINVAL; |
| -- |
| 2.43.0 |
| |
