| From e88d99082195b5431b03462b40f29870741bfe77 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 23 Apr 2024 14:06:28 +0800 |
| Subject: drm/amdgpu: fix uninitialized scalar variable warning |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Tim Huang <Tim.Huang@amd.com> |
| |
| [ Upstream commit 9a5f15d2a29d06ce5bd50919da7221cda92afb69 ] |
| |
| Clear warning that uses uninitialized value fw_size. |
| |
| Signed-off-by: Tim Huang <Tim.Huang@amd.com> |
| Reviewed-by: Christian Kรถnig <christian.koenig@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c |
| index b803e785d3aff..e9e0e7328c4e1 100644 |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c |
| @@ -1004,7 +1004,8 @@ void amdgpu_gfx_cp_init_microcode(struct amdgpu_device *adev, |
| fw_size = le32_to_cpu(cp_hdr_v2_0->data_size_bytes); |
| break; |
| default: |
| - break; |
| + dev_err(adev->dev, "Invalid ucode id %u\n", ucode_id); |
| + return; |
| } |
| |
| if (adev->firmware.load_type == AMDGPU_FW_LOAD_PSP) { |
| -- |
| 2.43.0 |
| |
