| From 5705c01ed464101432660bd71bf2b8ae8c05a539 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 13 Feb 2025 10:05:14 -0700 |
| Subject: nvme/ioctl: add missing space in err message |
| |
| From: Caleb Sander Mateos <csander@purestorage.com> |
| |
| [ Upstream commit 487a3ea7b1b8ba2ca7d2c2bb3c3594dc360d6261 ] |
| |
| nvme_validate_passthru_nsid() logs an err message whose format string is |
| split over 2 lines. There is a missing space between the two pieces, |
| resulting in log lines like "... does not match nsid (1)of namespace". |
| Add the missing space between ")" and "of". Also combine the format |
| string pieces onto a single line to make the err message easier to grep. |
| |
| Fixes: e7d4b5493a2d ("nvme: factor out a nvme_validate_passthru_nsid helper") |
| Signed-off-by: Caleb Sander Mateos <csander@purestorage.com> |
| Reviewed-by: Christoph Hellwig <hch@lst.de> |
| Signed-off-by: Keith Busch <kbusch@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/nvme/host/ioctl.c | 3 +-- |
| 1 file changed, 1 insertion(+), 2 deletions(-) |
| |
| diff --git a/drivers/nvme/host/ioctl.c b/drivers/nvme/host/ioctl.c |
| index a96976b22fa79..61af1583356c2 100644 |
| --- a/drivers/nvme/host/ioctl.c |
| +++ b/drivers/nvme/host/ioctl.c |
| @@ -276,8 +276,7 @@ static bool nvme_validate_passthru_nsid(struct nvme_ctrl *ctrl, |
| { |
| if (ns && nsid != ns->head->ns_id) { |
| dev_err(ctrl->device, |
| - "%s: nsid (%u) in cmd does not match nsid (%u)" |
| - "of namespace\n", |
| + "%s: nsid (%u) in cmd does not match nsid (%u) of namespace\n", |
| current->comm, nsid, ns->head->ns_id); |
| return false; |
| } |
| -- |
| 2.39.5 |
| |
