| From 8450eab7171bdac790f40def130960e1cd019bf2 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 4 Mar 2025 14:41:57 +0100 |
| Subject: drm/bochs: Fix DPMS regression |
| |
| From: Takashi Iwai <tiwai@suse.de> |
| |
| [ Upstream commit 80da96d735094ea22985ced98bc57fe3a4422921 ] |
| |
| The recent rewrite with the use of regular atomic helpers broke the |
| DPMS unblanking on X11. Fix it by moving the call of |
| bochs_hw_blank(false) from CRTC mode_set_nofb() to atomic_enable(). |
| |
| Fixes: 2037174993c8 ("drm/bochs: Use regular atomic helpers") |
| Link: https://bugzilla.suse.com/show_bug.cgi?id=1238209 |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> |
| Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20250304134203.20534-1-tiwai@suse.de |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/tiny/bochs.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/tiny/bochs.c b/drivers/gpu/drm/tiny/bochs.c |
| index 6f91ff1dbf7e2..4e7d49fb9e6e6 100644 |
| --- a/drivers/gpu/drm/tiny/bochs.c |
| +++ b/drivers/gpu/drm/tiny/bochs.c |
| @@ -335,8 +335,6 @@ static void bochs_hw_setmode(struct bochs_device *bochs, struct drm_display_mode |
| bochs->xres, bochs->yres, bochs->bpp, |
| bochs->yres_virtual); |
| |
| - bochs_hw_blank(bochs, false); |
| - |
| bochs_dispi_write(bochs, VBE_DISPI_INDEX_ENABLE, 0); |
| bochs_dispi_write(bochs, VBE_DISPI_INDEX_BPP, bochs->bpp); |
| bochs_dispi_write(bochs, VBE_DISPI_INDEX_XRES, bochs->xres); |
| @@ -506,6 +504,9 @@ static int bochs_crtc_helper_atomic_check(struct drm_crtc *crtc, |
| static void bochs_crtc_helper_atomic_enable(struct drm_crtc *crtc, |
| struct drm_atomic_state *state) |
| { |
| + struct bochs_device *bochs = to_bochs_device(crtc->dev); |
| + |
| + bochs_hw_blank(bochs, false); |
| } |
| |
| static void bochs_crtc_helper_atomic_disable(struct drm_crtc *crtc, |
| -- |
| 2.39.5 |
| |