| From da64a2359092ceec4f9dea5b329d0aef20104217 Mon Sep 17 00:00:00 2001 |
| From: Tiezhu Yang <yangtiezhu@loongson.cn> |
| Date: Sat, 8 Mar 2025 13:50:45 +0800 |
| Subject: LoongArch: Convert unreachable() to BUG() |
| |
| From: Tiezhu Yang <yangtiezhu@loongson.cn> |
| |
| commit da64a2359092ceec4f9dea5b329d0aef20104217 upstream. |
| |
| When compiling on LoongArch, there exists the following objtool warning |
| in arch/loongarch/kernel/machine_kexec.o: |
| |
| kexec_reboot() falls through to next function crash_shutdown_secondary() |
| |
| Avoid using unreachable() as it can (and will in the absence of UBSAN) |
| generate fall-through code. Use BUG() so we get a "break BRK_BUG" trap |
| (with unreachable annotation). |
| |
| Cc: stable@vger.kernel.org # 6.12+ |
| Acked-by: Josh Poimboeuf <jpoimboe@kernel.org> |
| Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> |
| Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| arch/loongarch/kernel/machine_kexec.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/arch/loongarch/kernel/machine_kexec.c |
| +++ b/arch/loongarch/kernel/machine_kexec.c |
| @@ -126,14 +126,14 @@ void kexec_reboot(void) |
| /* All secondary cpus go to kexec_smp_wait */ |
| if (smp_processor_id() > 0) { |
| relocated_kexec_smp_wait(NULL); |
| - unreachable(); |
| + BUG(); |
| } |
| #endif |
| |
| do_kexec = (void *)reboot_code_buffer; |
| do_kexec(efi_boot, cmdline_ptr, systable_ptr, start_addr, first_ind_entry); |
| |
| - unreachable(); |
| + BUG(); |
| } |
| |
| |
