| From ae313542922cebb20c64e23095c6e8e509847562 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 2 May 2025 13:10:35 +0200 |
| Subject: spi: loopback-test: Do not split 1024-byte hexdumps |
| |
| From: Geert Uytterhoeven <geert+renesas@glider.be> |
| |
| [ Upstream commit a73fa3690a1f3014d6677e368dce4e70767a6ba2 ] |
| |
| spi_test_print_hex_dump() prints buffers holding less than 1024 bytes in |
| full. Larger buffers are truncated: only the first 512 and the last 512 |
| bytes are printed, separated by a truncation message. The latter is |
| confusing in case the buffer holds exactly 1024 bytes, as all data is |
| printed anyway. |
| |
| Fix this by printing buffers holding up to and including 1024 bytes in |
| full. |
| |
| Fixes: 84e0c4e5e2c4ef42 ("spi: add loopback test driver to allow for spi_master regression tests") |
| Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> |
| Link: https://patch.msgid.link/37ee1bc90c6554c9347040adabf04188c8f704aa.1746184171.git.geert+renesas@glider.be |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/spi/spi-loopback-test.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c |
| index 31a878d9458d9..7740f94847a88 100644 |
| --- a/drivers/spi/spi-loopback-test.c |
| +++ b/drivers/spi/spi-loopback-test.c |
| @@ -420,7 +420,7 @@ MODULE_LICENSE("GPL"); |
| static void spi_test_print_hex_dump(char *pre, const void *ptr, size_t len) |
| { |
| /* limit the hex_dump */ |
| - if (len < 1024) { |
| + if (len <= 1024) { |
| print_hex_dump(KERN_INFO, pre, |
| DUMP_PREFIX_OFFSET, 16, 1, |
| ptr, len, 0); |
| -- |
| 2.39.5 |
| |
