| From 701480e9f5516d79d9fb02619ff4eac69b804728 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 30 Jul 2025 14:49:06 +0200 |
| Subject: ASoC: Intel: avs: Fix uninitialized pointer error in probe() |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Cezary Rojewski <cezary.rojewski@intel.com> |
| |
| [ Upstream commit 11f74f48c14c1f4fe16541900ea5944c42e30ccf ] |
| |
| If pcim_request_all_regions() fails, error path operates on |
| uninitialized 'bus' pointer. Found out by Coverity static analyzer. |
| |
| Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> |
| Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com> |
| Link: https://patch.msgid.link/20250730124906.351798-1-cezary.rojewski@intel.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/intel/avs/core.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/intel/avs/core.c b/sound/soc/intel/avs/core.c |
| index ec1b3f55cb5c..d45e9279df27 100644 |
| --- a/sound/soc/intel/avs/core.c |
| +++ b/sound/soc/intel/avs/core.c |
| @@ -446,6 +446,8 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) |
| adev = devm_kzalloc(dev, sizeof(*adev), GFP_KERNEL); |
| if (!adev) |
| return -ENOMEM; |
| + bus = &adev->base.core; |
| + |
| ret = avs_bus_init(adev, pci, id); |
| if (ret < 0) { |
| dev_err(dev, "failed to init avs bus: %d\n", ret); |
| @@ -456,7 +458,6 @@ static int avs_pci_probe(struct pci_dev *pci, const struct pci_device_id *id) |
| if (ret < 0) |
| return ret; |
| |
| - bus = &adev->base.core; |
| bus->addr = pci_resource_start(pci, 0); |
| bus->remap_addr = pci_ioremap_bar(pci, 0); |
| if (!bus->remap_addr) { |
| -- |
| 2.39.5 |
| |
