| From 24a195ef90f43c17dc7ba158bb995dc4a4ae49ba Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 15 Jul 2025 14:44:35 +0000 |
| Subject: drm/amd/pm: fix null pointer access |
| |
| From: Umio Yasuno <coelacanth_dream@protonmail.com> |
| |
| [ Upstream commit d524d40e3a6152a3ea1125af729f8cd8ca65efde ] |
| |
| Writing a string without delimiters (' ', '\n', '\0') to the under |
| gpu_od/fan_ctrl sysfs or pp_power_profile_mode for the CUSTOM profile |
| will result in a null pointer dereference. |
| |
| Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/4401 |
| Signed-off-by: Umio Yasuno <coelacanth_dream@protonmail.com> |
| Acked-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/pm/amdgpu_pm.c | 5 +++++ |
| 1 file changed, 5 insertions(+) |
| |
| diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c |
| index edd9895b46c0..39ee81085088 100644 |
| --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c |
| +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c |
| @@ -1398,6 +1398,8 @@ static ssize_t amdgpu_set_pp_power_profile_mode(struct device *dev, |
| if (ret) |
| return -EINVAL; |
| parameter_size++; |
| + if (!tmp_str) |
| + break; |
| while (isspace(*tmp_str)) |
| tmp_str++; |
| } |
| @@ -3645,6 +3647,9 @@ static int parse_input_od_command_lines(const char *buf, |
| return -EINVAL; |
| parameter_size++; |
| |
| + if (!tmp_str) |
| + break; |
| + |
| while (isspace(*tmp_str)) |
| tmp_str++; |
| } |
| -- |
| 2.39.5 |
| |
