| From 0cda8ea1221bf2815898e372157ae7417eca6876 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 9 May 2025 11:26:55 +0200 |
| Subject: imx8m-blk-ctrl: set ISI panic write hurry level |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Krzysztof Hałasa <khalasa@piap.pl> |
| |
| [ Upstream commit c01fba0b4869cada5403fffff416cd1675dba078 ] |
| |
| Apparently, ISI needs cache settings similar to LCDIF. |
| Otherwise we get artefacts in the image. |
| Tested on i.MX8MP. |
| |
| Signed-off-by: Krzysztof Hałasa <khalasa@piap.pl> |
| Link: https://lore.kernel.org/r/m3ldr69lsw.fsf@t19.piap.pl |
| Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/pmdomain/imx/imx8m-blk-ctrl.c | 10 ++++++++++ |
| 1 file changed, 10 insertions(+) |
| |
| diff --git a/drivers/pmdomain/imx/imx8m-blk-ctrl.c b/drivers/pmdomain/imx/imx8m-blk-ctrl.c |
| index 912802b5215b..5c83e5599f1e 100644 |
| --- a/drivers/pmdomain/imx/imx8m-blk-ctrl.c |
| +++ b/drivers/pmdomain/imx/imx8m-blk-ctrl.c |
| @@ -665,6 +665,11 @@ static const struct imx8m_blk_ctrl_data imx8mn_disp_blk_ctl_dev_data = { |
| #define LCDIF_1_RD_HURRY GENMASK(15, 13) |
| #define LCDIF_0_RD_HURRY GENMASK(12, 10) |
| |
| +#define ISI_CACHE_CTRL 0x50 |
| +#define ISI_V_WR_HURRY GENMASK(28, 26) |
| +#define ISI_U_WR_HURRY GENMASK(25, 23) |
| +#define ISI_Y_WR_HURRY GENMASK(22, 20) |
| + |
| static int imx8mp_media_power_notifier(struct notifier_block *nb, |
| unsigned long action, void *data) |
| { |
| @@ -694,6 +699,11 @@ static int imx8mp_media_power_notifier(struct notifier_block *nb, |
| regmap_set_bits(bc->regmap, LCDIF_ARCACHE_CTRL, |
| FIELD_PREP(LCDIF_1_RD_HURRY, 7) | |
| FIELD_PREP(LCDIF_0_RD_HURRY, 7)); |
| + /* Same here for ISI */ |
| + regmap_set_bits(bc->regmap, ISI_CACHE_CTRL, |
| + FIELD_PREP(ISI_V_WR_HURRY, 7) | |
| + FIELD_PREP(ISI_U_WR_HURRY, 7) | |
| + FIELD_PREP(ISI_Y_WR_HURRY, 7)); |
| } |
| |
| return NOTIFY_OK; |
| -- |
| 2.39.5 |
| |
