| From 76102f1acc399b67700cfc2fbce63b6c3ef37d2c Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 8 May 2025 10:37:45 +0200 |
| Subject: media: v4l2-common: Reduce warnings about missing V4L2_CID_LINK_FREQ |
| control |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> |
| |
| [ Upstream commit 5a0abb8909b9dcf347fce1d201ac6686ac33fd64 ] |
| |
| When operating a pipeline with a missing V4L2_CID_LINK_FREQ control this |
| two line warning is printed each time the pipeline is started. Reduce |
| this excessive logging by only warning once for the missing control. |
| |
| Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> |
| Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> |
| Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/media/v4l2-core/v4l2-common.c | 8 ++++---- |
| 1 file changed, 4 insertions(+), 4 deletions(-) |
| |
| diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c |
| index bd160a8c9efe..e1fc8fe43b74 100644 |
| --- a/drivers/media/v4l2-core/v4l2-common.c |
| +++ b/drivers/media/v4l2-core/v4l2-common.c |
| @@ -505,10 +505,10 @@ s64 __v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler, |
| |
| freq = div_u64(v4l2_ctrl_g_ctrl_int64(ctrl) * mul, div); |
| |
| - pr_warn("%s: Link frequency estimated using pixel rate: result might be inaccurate\n", |
| - __func__); |
| - pr_warn("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", |
| - __func__); |
| + pr_warn_once("%s: Link frequency estimated using pixel rate: result might be inaccurate\n", |
| + __func__); |
| + pr_warn_once("%s: Consider implementing support for V4L2_CID_LINK_FREQ in the transmitter driver\n", |
| + __func__); |
| } |
| |
| return freq > 0 ? freq : -EINVAL; |
| -- |
| 2.39.5 |
| |
