| From e60845265cb8d991d04da73613ddfadd9f5d8c48 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 10 Nov 2025 20:56:46 +0530 |
| Subject: ASoC: SDCA: bug fix while parsing mipi-sdca-control-cn-list |
| |
| From: Niranjan H Y <niranjan.hy@ti.com> |
| |
| [ Upstream commit eb2d6774cc0d9d6ab8f924825695a85c14b2e0c2 ] |
| |
| "struct sdca_control" declares "values" field as integer array. |
| But the memory allocated to it is of char array. This causes |
| crash for sdca_parse_function API. This patch addresses the |
| issue by allocating correct data size. |
| |
| Signed-off-by: Niranjan H Y <niranjan.hy@ti.com> |
| Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> |
| Link: https://patch.msgid.link/20251110152646.192-1-niranjan.hy@ti.com |
| Signed-off-by: Mark Brown <broonie@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/soc/sdca/sdca_functions.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/sound/soc/sdca/sdca_functions.c b/sound/soc/sdca/sdca_functions.c |
| index 13f68f7b6dd6a..0ccb6775f4de3 100644 |
| --- a/sound/soc/sdca/sdca_functions.c |
| +++ b/sound/soc/sdca/sdca_functions.c |
| @@ -894,7 +894,8 @@ static int find_sdca_entity_control(struct device *dev, struct sdca_entity *enti |
| return ret; |
| } |
| |
| - control->values = devm_kzalloc(dev, hweight64(control->cn_list), GFP_KERNEL); |
| + control->values = devm_kcalloc(dev, hweight64(control->cn_list), |
| + sizeof(int), GFP_KERNEL); |
| if (!control->values) |
| return -ENOMEM; |
| |
| -- |
| 2.51.0 |
| |
