| From 5c6a0a9acb8dfbabc0a6a2bf36cb5b242949ebd8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 20 Aug 2025 17:04:26 -0700 |
| Subject: drm/msm: Fix missing VM_BIND offset/range validation |
| |
| From: Rob Clark <robin.clark@oss.qualcomm.com> |
| |
| [ Upstream commit 3a3bef68a6c15d079646a964ebc4dc8bb0aedb06 ] |
| |
| We need to reject the MAP op if offset+range is larger than the BO size. |
| |
| Reported-by: Connor Abbott <cwabbott0@gmail.com> |
| Fixes: 2e6a8a1fe2b2 ("drm/msm: Add VM_BIND ioctl") |
| Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com> |
| Tested-by: Connor Abbott <cwabbott0@gmail.com> |
| Patchwork: https://patchwork.freedesktop.org/patch/669781/ |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/msm/msm_gem_vma.c | 6 ++++++ |
| 1 file changed, 6 insertions(+) |
| |
| diff --git a/drivers/gpu/drm/msm/msm_gem_vma.c b/drivers/gpu/drm/msm/msm_gem_vma.c |
| index 209154be5efcc..381a0853c05ba 100644 |
| --- a/drivers/gpu/drm/msm/msm_gem_vma.c |
| +++ b/drivers/gpu/drm/msm/msm_gem_vma.c |
| @@ -1080,6 +1080,12 @@ vm_bind_job_lookup_ops(struct msm_vm_bind_job *job, struct drm_msm_vm_bind *args |
| |
| op->obj = obj; |
| cnt++; |
| + |
| + if ((op->range + op->obj_offset) > obj->size) { |
| + ret = UERR(EINVAL, dev, "invalid range: %016llx + %016llx > %016zx\n", |
| + op->range, op->obj_offset, obj->size); |
| + goto out_unlock; |
| + } |
| } |
| |
| *nr_bos = cnt; |
| -- |
| 2.51.0 |
| |
