| From 98c1e291c33149eb804bb3002f3210b4d4173d96 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 9 Sep 2025 23:07:47 +0200 |
| Subject: tools: ynl: fix undefined variable name |
| MIME-Version: 1.0 |
| Content-Type: text/plain; charset=UTF-8 |
| Content-Transfer-Encoding: 8bit |
| |
| From: Matthieu Baerts (NGI0) <matttbe@kernel.org> |
| |
| [ Upstream commit 7a3aaaa9fce710938c3557e5708ba5b00dd38226 ] |
| |
| This variable used in the error path was not defined according to Ruff. |
| msg_format.attr_set is used instead, presumably the one that was |
| supposed to be used originally. |
| |
| This is linked to Ruff error F821 [1]: |
| |
| An undefined name is likely to raise NameError at runtime. |
| |
| Fixes: 1769e2be4baa ("tools/net/ynl: Add 'sub-message' attribute decoding to ynl") |
| Link: https://docs.astral.sh/ruff/rules/undefined-name/ [1] |
| Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> |
| Reviewed-by: Donald Hunter <donald.hunter@gmail.com> |
| Reviewed-by: Asbjørn Sloth Tønnesen <ast@fiberby.net> |
| Link: https://patch.msgid.link/20250909-net-next-ynl-ruff-v1-1-238c2bccdd99@kernel.org |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| tools/net/ynl/pyynl/lib/ynl.py | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/tools/net/ynl/pyynl/lib/ynl.py b/tools/net/ynl/pyynl/lib/ynl.py |
| index 8244a5f440b2b..15ddb0b1adb63 100644 |
| --- a/tools/net/ynl/pyynl/lib/ynl.py |
| +++ b/tools/net/ynl/pyynl/lib/ynl.py |
| @@ -746,7 +746,7 @@ class YnlFamily(SpecFamily): |
| subdict = self._decode(NlAttrs(attr.raw, offset), msg_format.attr_set) |
| decoded.update(subdict) |
| else: |
| - raise Exception(f"Unknown attribute-set '{attr_space}' when decoding '{attr_spec.name}'") |
| + raise Exception(f"Unknown attribute-set '{msg_format.attr_set}' when decoding '{attr_spec.name}'") |
| return decoded |
| |
| def _decode(self, attrs, space, outer_attrs = None): |
| -- |
| 2.51.0 |
| |