| From b6133af81e22702cdec186dbbc49c9757c0b0354 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 25 Apr 2024 17:26:18 +0300 |
| Subject: drm/panel: ili9341: Respect deferred probe |
| |
| From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| |
| [ Upstream commit 740fc1e0509be3f7e2207e89125b06119ed62943 ] |
| |
| GPIO controller might not be available when driver is being probed. |
| There are plenty of reasons why, one of which is deferred probe. |
| |
| Since GPIOs are optional, return any error code we got to the upper |
| layer, including deferred probe. With that in mind, use dev_err_probe() |
| in order to avoid spamming the logs. |
| |
| Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver") |
| Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
| Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> |
| Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> |
| Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev> |
| Link: https://lore.kernel.org/r/20240425142706.2440113-3-andriy.shevchenko@linux.intel.com |
| Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> |
| Link: https://patchwork.freedesktop.org/patch/msgid/20240425142706.2440113-3-andriy.shevchenko@linux.intel.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/panel/panel-ilitek-ili9341.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c |
| index 7584ddb0e4416..24c74c56e5648 100644 |
| --- a/drivers/gpu/drm/panel/panel-ilitek-ili9341.c |
| +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9341.c |
| @@ -715,11 +715,11 @@ static int ili9341_probe(struct spi_device *spi) |
| |
| reset = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); |
| if (IS_ERR(reset)) |
| - dev_err(dev, "Failed to get gpio 'reset'\n"); |
| + return dev_err_probe(dev, PTR_ERR(reset), "Failed to get gpio 'reset'\n"); |
| |
| dc = devm_gpiod_get_optional(dev, "dc", GPIOD_OUT_LOW); |
| if (IS_ERR(dc)) |
| - dev_err(dev, "Failed to get gpio 'dc'\n"); |
| + return dev_err_probe(dev, PTR_ERR(dc), "Failed to get gpio 'dc'\n"); |
| |
| if (!strcmp(id->name, "sf-tc240t-9370-t")) |
| return ili9341_dpi_probe(spi, dc, reset); |
| -- |
| 2.43.0 |
| |
