| From 0d2a07bbac724373f81ab781814b5c4547aed45a Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 25 Apr 2024 15:16:40 +0800 |
| Subject: drm/amdgpu: fix the warning about the expression (int)size - len |
| |
| From: Jesse Zhang <jesse.zhang@amd.com> |
| |
| [ Upstream commit ea686fef5489ef7a2450a9fdbcc732b837fb46a8 ] |
| |
| Converting size from size_t to int may overflow. |
| v2: keep reverse xmas tree order (Christian) |
| |
| Signed-off-by: Jesse Zhang <jesse.zhang@amd.com> |
| Reviewed-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Alex Deucher <alexander.deucher@amd.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| index 418ff7cd662da..1c2c9ff9d39df 100644 |
| --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c |
| @@ -2052,12 +2052,13 @@ static ssize_t amdgpu_reset_dump_register_list_write(struct file *f, |
| struct amdgpu_device *adev = (struct amdgpu_device *)file_inode(f)->i_private; |
| char reg_offset[11]; |
| uint32_t *new = NULL, *tmp = NULL; |
| - int ret, i = 0, len = 0; |
| + unsigned int len = 0; |
| + int ret, i = 0; |
| |
| do { |
| memset(reg_offset, 0, 11); |
| if (copy_from_user(reg_offset, buf + len, |
| - min(10, ((int)size-len)))) { |
| + min(10, (size-len)))) { |
| ret = -EFAULT; |
| goto error_free; |
| } |
| -- |
| 2.43.0 |
| |
