| From 7a7445a46f1f0722ec92730f283c1df953ba12bb Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Thu, 4 Jul 2024 10:19:44 -0500 |
| Subject: net: bcmasp: Fix error code in probe() |
| |
| From: Dan Carpenter <dan.carpenter@linaro.org> |
| |
| [ Upstream commit 0c754d9d86ffdf2f86b4272b25d759843fb62fd8 ] |
| |
| Return an error code if bcmasp_interface_create() fails. Don't return |
| success. |
| |
| Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller") |
| Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> |
| Reviewed-by: Michal Kubiak <michal.kubiak@intel.com> |
| Reviewed-by: Justin Chen <justin.chen@broadcom.com> |
| Link: https://patch.msgid.link/ZoWKBkHH9D1fqV4r@stanley.mountain |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/broadcom/asp2/bcmasp.c | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c |
| index 4b6bf2764bef7..d9e9ec2e8945d 100644 |
| --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c |
| +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c |
| @@ -1306,6 +1306,7 @@ static int bcmasp_probe(struct platform_device *pdev) |
| dev_err(dev, "Cannot create eth interface %d\n", i); |
| bcmasp_remove_intfs(priv); |
| of_node_put(intf_node); |
| + ret = -ENOMEM; |
| goto of_put_exit; |
| } |
| list_add_tail(&intf->list, &priv->intfs); |
| -- |
| 2.43.0 |
| |
