| From ced8cfc9484666624d52c5cf8241e750eabcf571 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Wed, 28 Feb 2024 10:56:49 -0500 |
| Subject: Bluetooth: msft: Fix memory leak |
| |
| From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> |
| |
| [ Upstream commit a6e06258f4c31eba0fcd503e19828b5f8fe7b08b ] |
| |
| Fix leaking buffer allocated to send MSFT_OP_LE_MONITOR_ADVERTISEMENT. |
| |
| Fixes: 9e14606d8f38 ("Bluetooth: msft: Extended monitor tracking by address filter") |
| Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| net/bluetooth/msft.c | 3 +++ |
| 1 file changed, 3 insertions(+) |
| |
| diff --git a/net/bluetooth/msft.c b/net/bluetooth/msft.c |
| index 630e3023273b2..9612c5d1b13f6 100644 |
| --- a/net/bluetooth/msft.c |
| +++ b/net/bluetooth/msft.c |
| @@ -875,6 +875,7 @@ static int msft_add_address_filter_sync(struct hci_dev *hdev, void *data) |
| remove = true; |
| goto done; |
| } |
| + |
| cp->sub_opcode = MSFT_OP_LE_MONITOR_ADVERTISEMENT; |
| cp->rssi_high = address_filter->rssi_high; |
| cp->rssi_low = address_filter->rssi_low; |
| @@ -887,6 +888,8 @@ static int msft_add_address_filter_sync(struct hci_dev *hdev, void *data) |
| |
| skb = __hci_cmd_sync(hdev, hdev->msft_opcode, size, cp, |
| HCI_CMD_TIMEOUT); |
| + kfree(cp); |
| + |
| if (IS_ERR(skb)) { |
| bt_dev_err(hdev, "Failed to enable address %pMR filter", |
| &address_filter->bdaddr); |
| -- |
| 2.43.0 |
| |
