| From SRS0=eEWY=JP=rostedt.homelinux.com=rostedt@kernel.org Tue Feb 6 12:33:33 2024 |
| From: Steven Rostedt <rostedt@goodmis.org> |
| Date: Tue, 06 Feb 2024 06:32:15 -0500 |
| Subject: eventfs: Remove unused d_parent pointer field |
| To: linux-kernel@vger.kernel.org, stable@vger.kernel.org |
| Cc: Linus Torvalds <torvalds@linux-foundation.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Sasha Levin <sashal@kernel.org>, Masami Hiramatsu <mhiramat@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>, Christian Brauner <brauner@kernel.org>, Al Viro <viro@ZenIV.linux.org.uk>, Ajay Kaher <ajay.kaher@broadcom.com> |
| Message-ID: <20240206113400.846719926@rostedt.homelinux.com> |
| |
| From: Linus Torvalds <torvalds@linux-foundation.org> |
| |
| commit 408600be78cdb8c650a97ecc7ff411cb216811b5 upstream. |
| |
| It's never used |
| |
| Link: https://lore.kernel.org/linux-trace-kernel/202401291043.e62e89dc-oliver.sang@intel.com/ |
| Link: https://lore.kernel.org/linux-trace-kernel/20240131185512.961772428@goodmis.org |
| |
| Cc: stable@vger.kernel.org |
| Cc: Masami Hiramatsu <mhiramat@kernel.org> |
| Cc: Mark Rutland <mark.rutland@arm.com> |
| Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> |
| Cc: Christian Brauner <brauner@kernel.org> |
| Cc: Al Viro <viro@ZenIV.linux.org.uk> |
| Cc: Ajay Kaher <ajay.kaher@broadcom.com> |
| Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| Fixes: c1504e510238 ("eventfs: Implement eventfs dir creation functions") |
| Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
| Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| fs/tracefs/event_inode.c | 4 +--- |
| fs/tracefs/internal.h | 2 -- |
| 2 files changed, 1 insertion(+), 5 deletions(-) |
| |
| --- a/fs/tracefs/event_inode.c |
| +++ b/fs/tracefs/event_inode.c |
| @@ -680,10 +680,8 @@ struct eventfs_inode *eventfs_create_dir |
| INIT_LIST_HEAD(&ei->list); |
| |
| mutex_lock(&eventfs_mutex); |
| - if (!parent->is_freed) { |
| + if (!parent->is_freed) |
| list_add_tail(&ei->list, &parent->children); |
| - ei->d_parent = parent->dentry; |
| - } |
| mutex_unlock(&eventfs_mutex); |
| |
| /* Was the parent freed? */ |
| --- a/fs/tracefs/internal.h |
| +++ b/fs/tracefs/internal.h |
| @@ -36,7 +36,6 @@ struct eventfs_attr { |
| * @name: the name of the directory to create |
| * @children: link list into the child eventfs_inode |
| * @dentry: the dentry of the directory |
| - * @d_parent: pointer to the parent's dentry |
| * @d_children: The array of dentries to represent the files when created |
| * @entry_attrs: Saved mode and ownership of the @d_children |
| * @attr: Saved mode and ownership of eventfs_inode itself |
| @@ -51,7 +50,6 @@ struct eventfs_inode { |
| const char *name; |
| struct list_head children; |
| struct dentry *dentry; /* Check is_freed to access */ |
| - struct dentry *d_parent; |
| struct dentry **d_children; |
| struct eventfs_attr *entry_attrs; |
| struct eventfs_attr attr; |