| From 0419373333c2f2024966d36261fd82a453281e80 Mon Sep 17 00:00:00 2001 |
| From: Hugo Villeneuve <hvilleneuve@dimonoff.com> |
| Date: Tue, 16 Jan 2024 16:29:58 -0500 |
| Subject: serial: max310x: set default value when reading clock ready bit |
| |
| From: Hugo Villeneuve <hvilleneuve@dimonoff.com> |
| |
| commit 0419373333c2f2024966d36261fd82a453281e80 upstream. |
| |
| If regmap_read() returns a non-zero value, the 'val' variable can be left |
| uninitialized. |
| |
| Clear it before calling regmap_read() to make sure we properly detect |
| the clock ready bit. |
| |
| Fixes: 4cf9a888fd3c ("serial: max310x: Check the clock readiness") |
| Cc: stable@vger.kernel.org |
| Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com> |
| Link: https://lore.kernel.org/r/20240116213001.3691629-2-hugo@hugovil.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/tty/serial/max310x.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/tty/serial/max310x.c |
| +++ b/drivers/tty/serial/max310x.c |
| @@ -641,7 +641,7 @@ static u32 max310x_set_ref_clk(struct de |
| |
| /* Wait for crystal */ |
| if (xtal) { |
| - unsigned int val; |
| + unsigned int val = 0; |
| msleep(10); |
| regmap_read(s->regmap, MAX310X_STS_IRQSTS_REG, &val); |
| if (!(val & MAX310X_STS_CLKREADY_BIT)) { |
