| From 8e84bb57fdd9cfc14962b0d31c8891a56c56f725 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 9 Apr 2024 16:00:55 +0200 |
| Subject: ACPI: disable -Wstringop-truncation |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit a3403d304708f60565582d60af4316289d0316a0 ] |
| |
| gcc -Wstringop-truncation warns about copying a string that results in a |
| missing nul termination: |
| |
| drivers/acpi/acpica/tbfind.c: In function 'acpi_tb_find_table': |
| drivers/acpi/acpica/tbfind.c:60:9: error: 'strncpy' specified bound 6 equals destination size [-Werror=stringop-truncation] |
| 60 | strncpy(header.oem_id, oem_id, ACPI_OEM_ID_SIZE); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| drivers/acpi/acpica/tbfind.c:61:9: error: 'strncpy' specified bound 8 equals destination size [-Werror=stringop-truncation] |
| 61 | strncpy(header.oem_table_id, oem_table_id, ACPI_OEM_TABLE_ID_SIZE); |
| | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
| |
| The code works as intended, and the warning could be addressed by using |
| a memcpy(), but turning the warning off for this file works equally well |
| and may be easier to merge. |
| |
| Fixes: 47c08729bf1c ("ACPICA: Fix for LoadTable operator, input strings") |
| Link: https://lore.kernel.org/lkml/CAJZ5v0hoUfv54KW7y4223Mn9E7D4xvR7whRFNLTBqCZMUxT50Q@mail.gmail.com/#t |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/acpi/acpica/Makefile | 1 + |
| 1 file changed, 1 insertion(+) |
| |
| diff --git a/drivers/acpi/acpica/Makefile b/drivers/acpi/acpica/Makefile |
| index 30f3fc13c29d1..8d18af396de92 100644 |
| --- a/drivers/acpi/acpica/Makefile |
| +++ b/drivers/acpi/acpica/Makefile |
| @@ -5,6 +5,7 @@ |
| |
| ccflags-y := -D_LINUX -DBUILDING_ACPICA |
| ccflags-$(CONFIG_ACPI_DEBUG) += -DACPI_DEBUG_OUTPUT |
| +CFLAGS_tbfind.o += $(call cc-disable-warning, stringop-truncation) |
| |
| # use acpi.o to put all files here into acpi.o modparam namespace |
| obj-y += acpi.o |
| -- |
| 2.43.0 |
| |
