| From 894360a18dd53f34c4ede9d05b28e73109cb1f87 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 26 Mar 2024 23:38:01 +0100 |
| Subject: enetc: avoid truncating error message |
| |
| From: Arnd Bergmann <arnd@arndb.de> |
| |
| [ Upstream commit 9046d581ed586f3c715357638ca12c0e84402002 ] |
| |
| As clang points out, the error message in enetc_setup_xdp_prog() |
| still does not fit in the buffer and will be truncated: |
| |
| drivers/net/ethernet/freescale/enetc/enetc.c:2771:3: error: 'snprintf' will always be truncated; specified size is 80, but format string expands to at least 87 [-Werror,-Wformat-truncation] |
| |
| Replace it with an even shorter message that should fit. |
| |
| Fixes: f968c56417f0 ("net: enetc: shorten enetc_setup_xdp_prog() error message to fit NETLINK_MAX_FMTMSG_LEN") |
| Signed-off-by: Arnd Bergmann <arnd@arndb.de> |
| Link: https://lore.kernel.org/r/20240326223825.4084412-3-arnd@kernel.org |
| Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c |
| index bfdbdab443ae0..5e6e1f7196f87 100644 |
| --- a/drivers/net/ethernet/freescale/enetc/enetc.c |
| +++ b/drivers/net/ethernet/freescale/enetc/enetc.c |
| @@ -2769,7 +2769,7 @@ static int enetc_setup_xdp_prog(struct net_device *ndev, struct bpf_prog *prog, |
| if (priv->min_num_stack_tx_queues + num_xdp_tx_queues > |
| priv->num_tx_rings) { |
| NL_SET_ERR_MSG_FMT_MOD(extack, |
| - "Reserving %d XDP TXQs does not leave a minimum of %d for stack (total %d)", |
| + "Reserving %d XDP TXQs leaves under %d for stack (total %d)", |
| num_xdp_tx_queues, |
| priv->min_num_stack_tx_queues, |
| priv->num_tx_rings); |
| -- |
| 2.43.0 |
| |
