| From 9d8c4f018e476188fb67ad7862dec719fd9b9489 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Mon, 15 Dec 2025 17:04:33 +0800 |
| Subject: ALSA: pcmcia: Fix resource leak in snd_pdacf_probe error path |
| |
| From: Haotian Zhang <vulab@iscas.ac.cn> |
| |
| [ Upstream commit 5032347c04ba7ff9ba878f262e075d745c06a2a8 ] |
| |
| When pdacf_config() fails, snd_pdacf_probe() returns the error code |
| directly without freeing the sound card resources allocated by |
| snd_card_new(), which leads to a memory leak. |
| |
| Add proper error handling to free the sound card and clear the card |
| list entry when pdacf_config() fails. |
| |
| Fixes: 15b99ac17295 ("[PATCH] pcmcia: add return value to _config() functions") |
| Suggested-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn> |
| Link: https://patch.msgid.link/20251215090433.211-1-vulab@iscas.ac.cn |
| Signed-off-by: Takashi Iwai <tiwai@suse.de> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| sound/pcmcia/pdaudiocf/pdaudiocf.c | 8 +++++++- |
| 1 file changed, 7 insertions(+), 1 deletion(-) |
| |
| diff --git a/sound/pcmcia/pdaudiocf/pdaudiocf.c b/sound/pcmcia/pdaudiocf/pdaudiocf.c |
| index 494460746614..7531e89e35da 100644 |
| --- a/sound/pcmcia/pdaudiocf/pdaudiocf.c |
| +++ b/sound/pcmcia/pdaudiocf/pdaudiocf.c |
| @@ -131,7 +131,13 @@ static int snd_pdacf_probe(struct pcmcia_device *link) |
| link->config_index = 1; |
| link->config_regs = PRESENT_OPTION; |
| |
| - return pdacf_config(link); |
| + err = pdacf_config(link); |
| + if (err < 0) { |
| + card_list[i] = NULL; |
| + snd_card_free(card); |
| + return err; |
| + } |
| + return 0; |
| } |
| |
| |
| -- |
| 2.51.0 |
| |