| From 8de678e72392b129684e553467dddb12a45359e8 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Tue, 23 Mar 2021 17:34:53 +0800 |
| Subject: drm/omap: dsi: Add missing IRQF_ONESHOT |
| |
| From: Yang Li <yang.lee@linux.alibaba.com> |
| |
| [ Upstream commit 0cafc8d88e6df446751669ec15adc9b807af4501 ] |
| |
| fixed the following coccicheck: |
| ./drivers/gpu/drm/omapdrm/dss/dsi.c:4329:7-27: ERROR: Threaded IRQ with |
| no primary handler requested without IRQF_ONESHOT |
| |
| Reported-by: Abaci Robot <abaci@linux.alibaba.com> |
| Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> |
| Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> |
| Fixes: 4c1b935fea54 ("drm/omap: dsi: move TE GPIO handling into core") |
| Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> |
| Link: https://patchwork.freedesktop.org/patch/msgid/1616492093-68237-1-git-send-email-yang.lee@linux.alibaba.com |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpu/drm/omapdrm/dss/dsi.c | 3 ++- |
| 1 file changed, 2 insertions(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c |
| index b31d750c425a..5f1722b040f4 100644 |
| --- a/drivers/gpu/drm/omapdrm/dss/dsi.c |
| +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c |
| @@ -4327,7 +4327,8 @@ static int omap_dsi_register_te_irq(struct dsi_data *dsi, |
| irq_set_status_flags(te_irq, IRQ_NOAUTOEN); |
| |
| err = request_threaded_irq(te_irq, NULL, omap_dsi_te_irq_handler, |
| - IRQF_TRIGGER_RISING, "TE", dsi); |
| + IRQF_TRIGGER_RISING | IRQF_ONESHOT, |
| + "TE", dsi); |
| if (err) { |
| dev_err(dsi->dev, "request irq failed with %d\n", err); |
| gpiod_put(dsi->te_gpio); |
| -- |
| 2.30.2 |
| |
