| From 12adef5b49e98eb181b4163c36e2998169e1379b Mon Sep 17 00:00:00 2001 |
| From: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| Date: Wed, 9 Apr 2014 11:56:09 +0200 |
| Subject: extcon: max14577: Fix probe failure on successful work queue |
| |
| From: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| |
| commit 12adef5b49e98eb181b4163c36e2998169e1379b upstream. |
| |
| In probe the driver queued delayed work for cable detection and |
| returned the result of queue_delayed_work() call. However the return |
| value of queue_delayed_work() does not indicate an error and in normal |
| condition it returns true which means successful work queue. |
| This effectively resulted in probe failure: |
| [ 2.088204] max14577-muic: probe of max77836-muic failed with error 1 |
| |
| Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> |
| Fixes: 962e56bfcf0b ("extcon: max14577: Add extcon-max14577 driver...") |
| Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/extcon/extcon-max14577.c | 7 +------ |
| 1 file changed, 1 insertion(+), 6 deletions(-) |
| |
| --- a/drivers/extcon/extcon-max14577.c |
| +++ b/drivers/extcon/extcon-max14577.c |
| @@ -710,13 +710,8 @@ static int max14577_muic_probe(struct pl |
| * driver should notify cable state to upper layer. |
| */ |
| INIT_DELAYED_WORK(&info->wq_detcable, max14577_muic_detect_cable_wq); |
| - ret = queue_delayed_work(system_power_efficient_wq, &info->wq_detcable, |
| + queue_delayed_work(system_power_efficient_wq, &info->wq_detcable, |
| delay_jiffies); |
| - if (ret < 0) { |
| - dev_err(&pdev->dev, |
| - "failed to schedule delayed work for cable detect\n"); |
| - goto err_extcon; |
| - } |
| |
| return ret; |
| |
