| From foo@baz Tue 04 Jun 2019 04:46:27 PM CEST |
| From: Daniel Axtens <dja@axtens.net> |
| Date: Wed, 31 Jan 2018 14:15:34 +1100 |
| Subject: bnx2x: disable GSO where gso_size is too big for hardware |
| |
| From: Daniel Axtens <dja@axtens.net> |
| |
| commit 8914a595110a6eca69a5e275b323f5d09e18f4f9 upstream. |
| |
| If a bnx2x card is passed a GSO packet with a gso_size larger than |
| ~9700 bytes, it will cause a firmware error that will bring the card |
| down: |
| |
| bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! |
| bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 |
| bnx2x: [bnx2x_mc_assert:736(enP24p1s0f0)]XSTORM_ASSERT_INDEX 0x0 = 0x00000000 0x25e43e47 0x00463e01 0x00010052 |
| bnx2x: [bnx2x_mc_assert:750(enP24p1s0f0)]Chip Revision: everest3, FW Version: 7_13_1 |
| ... (dump of values continues) ... |
| |
| Detect when the mac length of a GSO packet is greater than the maximum |
| packet size (9700 bytes) and disable GSO. |
| |
| Signed-off-by: Daniel Axtens <dja@axtens.net> |
| Reviewed-by: Eric Dumazet <edumazet@google.com> |
| Signed-off-by: David S. Miller <davem@davemloft.net> |
| Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| --- |
| drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 18 ++++++++++++++++++ |
| 1 file changed, 18 insertions(+) |
| |
| --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |
| +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |
| @@ -12824,6 +12824,24 @@ static netdev_features_t bnx2x_features_ |
| struct net_device *dev, |
| netdev_features_t features) |
| { |
| + /* |
| + * A skb with gso_size + header length > 9700 will cause a |
| + * firmware panic. Drop GSO support. |
| + * |
| + * Eventually the upper layer should not pass these packets down. |
| + * |
| + * For speed, if the gso_size is <= 9000, assume there will |
| + * not be 700 bytes of headers and pass it through. Only do a |
| + * full (slow) validation if the gso_size is > 9000. |
| + * |
| + * (Due to the way SKB_BY_FRAGS works this will also do a full |
| + * validation in that case.) |
| + */ |
| + if (unlikely(skb_is_gso(skb) && |
| + (skb_shinfo(skb)->gso_size > 9000) && |
| + !skb_gso_validate_mac_len(skb, 9700))) |
| + features &= ~NETIF_F_GSO_MASK; |
| + |
| features = vlan_features_check(skb, features); |
| return vxlan_features_check(skb, features); |
| } |