| From 83a43ff80a566de8718dfc6565545a0080ec1fb5 Mon Sep 17 00:00:00 2001 |
| From: Yu Kuai <yukuai3@huawei.com> |
| Date: Tue, 17 Nov 2020 09:14:30 +0800 |
| Subject: usb: chipidea: ci_hdrc_imx: add missing put_device() call in usbmisc_get_init_data() |
| |
| From: Yu Kuai <yukuai3@huawei.com> |
| |
| commit 83a43ff80a566de8718dfc6565545a0080ec1fb5 upstream. |
| |
| if of_find_device_by_node() succeed, usbmisc_get_init_data() doesn't have |
| a corresponding put_device(). Thus add put_device() to fix the exception |
| handling for this function implementation. |
| |
| Fixes: ef12da914ed6 ("usb: chipidea: imx: properly check for usbmisc") |
| Signed-off-by: Yu Kuai <yukuai3@huawei.com> |
| Cc: stable <stable@vger.kernel.org> |
| Link: https://lore.kernel.org/r/20201117011430.642589-1-yukuai3@huawei.com |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/usb/chipidea/ci_hdrc_imx.c | 6 +++++- |
| 1 file changed, 5 insertions(+), 1 deletion(-) |
| |
| --- a/drivers/usb/chipidea/ci_hdrc_imx.c |
| +++ b/drivers/usb/chipidea/ci_hdrc_imx.c |
| @@ -133,9 +133,13 @@ static struct imx_usbmisc_data *usbmisc_ |
| misc_pdev = of_find_device_by_node(args.np); |
| of_node_put(args.np); |
| |
| - if (!misc_pdev || !platform_get_drvdata(misc_pdev)) |
| + if (!misc_pdev) |
| return ERR_PTR(-EPROBE_DEFER); |
| |
| + if (!platform_get_drvdata(misc_pdev)) { |
| + put_device(&misc_pdev->dev); |
| + return ERR_PTR(-EPROBE_DEFER); |
| + } |
| data->dev = &misc_pdev->dev; |
| |
| if (of_find_property(np, "disable-over-current", NULL)) |
