| From 08ef006907255e2a072c0fc2ab28ac6fdf9ee911 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Sun, 15 Feb 2026 12:05:55 -0800 |
| Subject: gpio: cdev: Avoid NULL dereference in linehandle_create() |
| |
| From: Douglas Anderson <dianders@chromium.org> |
| |
| [ Upstream commit 6af6be278e3ba2ffb6af5b796c89dfb3f5d9063e ] |
| |
| In linehandle_create(), there is a statement like this: |
| retain_and_null_ptr(lh); |
| |
| Soon after, there is a debug printout that dereferences "lh", which |
| will crash things. |
| |
| Avoid the crash by using handlereq.lines, which is the same value. |
| |
| Fixes: da7e394bf58f ("gpio: convert linehandle_create() to FD_PREPARE()") |
| Signed-off-by: Douglas Anderson <dianders@chromium.org> |
| Link: https://patch.msgid.link/20260215120555.v2.1.I77c3eb563271c21870379eefd16ebbc4e09635bb@changeid |
| Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| drivers/gpio/gpiolib-cdev.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c |
| index 2adc3c0709082..189127721e383 100644 |
| --- a/drivers/gpio/gpiolib-cdev.c |
| +++ b/drivers/gpio/gpiolib-cdev.c |
| @@ -388,7 +388,7 @@ static int linehandle_create(struct gpio_device *gdev, void __user *ip) |
| fd_publish(fdf); |
| |
| dev_dbg(&gdev->dev, "registered chardev handle for %d lines\n", |
| - lh->num_descs); |
| + handlereq.lines); |
| |
| return 0; |
| } |
| -- |
| 2.51.0 |
| |
