| From a918c813fef3d9d046174a64508226334be7b3c7 Mon Sep 17 00:00:00 2001 |
| From: Sasha Levin <sashal@kernel.org> |
| Date: Fri, 7 Jun 2024 03:36:12 +0900 |
| Subject: modpost: do not warn about missing MODULE_DESCRIPTION() for vmlinux.o |
| |
| From: Masahiro Yamada <masahiroy@kernel.org> |
| |
| [ Upstream commit 9185afeac2a3dcce8300a5684291a43c2838cfd6 ] |
| |
| Building with W=1 incorrectly emits the following warning: |
| |
| WARNING: modpost: missing MODULE_DESCRIPTION() in vmlinux.o |
| |
| This check should apply only to modules. |
| |
| Fixes: 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing") |
| Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> |
| Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> |
| Signed-off-by: Sasha Levin <sashal@kernel.org> |
| --- |
| scripts/mod/modpost.c | 5 +++-- |
| 1 file changed, 3 insertions(+), 2 deletions(-) |
| |
| diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c |
| index 269bd79bcd9ad..828d5cc367169 100644 |
| --- a/scripts/mod/modpost.c |
| +++ b/scripts/mod/modpost.c |
| @@ -1684,10 +1684,11 @@ static void read_symbols(const char *modname) |
| namespace = get_next_modinfo(&info, "import_ns", |
| namespace); |
| } |
| + |
| + if (extra_warn && !get_modinfo(&info, "description")) |
| + warn("missing MODULE_DESCRIPTION() in %s\n", modname); |
| } |
| |
| - if (extra_warn && !get_modinfo(&info, "description")) |
| - warn("missing MODULE_DESCRIPTION() in %s\n", modname); |
| for (sym = info.symtab_start; sym < info.symtab_stop; sym++) { |
| symname = remove_dot(info.strtab + sym->st_name); |
| |
| -- |
| 2.43.0 |
| |
