| From 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf Mon Sep 17 00:00:00 2001 |
| From: Axel Lin <axel.lin@ingics.com> |
| Date: Wed, 30 Jul 2014 11:13:52 +0800 |
| Subject: hwmon: (ads1015) Fix off-by-one for valid channel index checking |
| |
| From: Axel Lin <axel.lin@ingics.com> |
| |
| commit 56de1377ad92f72ee4e5cb0faf7a9b6048fdf0bf upstream. |
| |
| Current code uses channel as array index, so the valid channel value is |
| 0 .. ADS1015_CHANNELS - 1. |
| |
| Signed-off-by: Axel Lin <axel.lin@ingics.com> |
| Signed-off-by: Guenter Roeck <linux@roeck-us.net> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
| |
| --- |
| drivers/hwmon/ads1015.c | 2 +- |
| 1 file changed, 1 insertion(+), 1 deletion(-) |
| |
| --- a/drivers/hwmon/ads1015.c |
| +++ b/drivers/hwmon/ads1015.c |
| @@ -198,7 +198,7 @@ static int ads1015_get_channels_config_o |
| } |
| |
| channel = be32_to_cpup(property); |
| - if (channel > ADS1015_CHANNELS) { |
| + if (channel >= ADS1015_CHANNELS) { |
| dev_err(&client->dev, |
| "invalid channel index %d on %s\n", |
| channel, node->full_name); |
