| From stefanr@s5r6.in-berlin.de Tue Nov 4 13:54:50 2008 |
| From: Stefan Richter <stefanr@s5r6.in-berlin.de> |
| Date: Mon, 27 Oct 2008 23:26:00 +0100 (CET) |
| Subject: firewire: fix setting tag and sy in iso transmission |
| To: stable@kernel.org |
| Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org |
| Message-ID: <tkrat.c6c9e197bd5d3af2@s5r6.in-berlin.de> |
| Content-Disposition: INLINE |
| |
| From: Stefan Richter <stefanr@s5r6.in-berlin.de> |
| |
| commit 7a1003449c693f0d57443c8786bbf19717921ae0 upstream |
| |
| Reported by Jay Fenlason: |
| The iso packet control accessors in fw-cdev.c had bogus masks. |
| |
| Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> |
| Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
| |
| --- |
| drivers/firewire/fw-cdev.c | 4 ++-- |
| 1 file changed, 2 insertions(+), 2 deletions(-) |
| |
| --- a/drivers/firewire/fw-cdev.c |
| +++ b/drivers/firewire/fw-cdev.c |
| @@ -720,8 +720,8 @@ static int ioctl_create_iso_context(stru |
| #define GET_PAYLOAD_LENGTH(v) ((v) & 0xffff) |
| #define GET_INTERRUPT(v) (((v) >> 16) & 0x01) |
| #define GET_SKIP(v) (((v) >> 17) & 0x01) |
| -#define GET_TAG(v) (((v) >> 18) & 0x02) |
| -#define GET_SY(v) (((v) >> 20) & 0x04) |
| +#define GET_TAG(v) (((v) >> 18) & 0x03) |
| +#define GET_SY(v) (((v) >> 20) & 0x0f) |
| #define GET_HEADER_LENGTH(v) (((v) >> 24) & 0xff) |
| |
| static int ioctl_queue_iso(struct client *client, void *buffer) |
